fix: use limited publishBrandInfo power, not all of chainStorage #61
+466
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 3 levels of boardAux power: just brands, TOFU, and full admin - add makeMarshal etc. to promise space under `endo1`
0xpatrickdev
approved these changes
Feb 15, 2024
| E.when(E(board).getId(key), boardId => E(boardAux).makeChildNode(boardId)); | ||
|
|
||
| const init = async (key, value) => { | ||
| store.init(key, value); |
There was a problem hiding this comment.
initis only allowed if the key does not already exist.Get,setand *deleteare only allowed if the key does already exist.
✅
|
|
||
| return harden({ | ||
| brandAuxPublisher: Far('BrandAuxPublisher', { publishBrandInfo }), | ||
| boardAuxTOFU: Far('BoardAuxTOFU', { publishBrandInfo, init }), |
There was a problem hiding this comment.
Trust On First Use.
Maybe should be renamed to "first come, first served".
IOU (and the rest of the consumers of this code) better documentation.
Comment on lines
+7
to
+11
| * endo1: { | ||
| * marshal: typeof import('@endo/marshal'); | ||
| * patterns: typeof import('@endo/patterns'); | ||
| * } | ||
| * }} Endo1Modules |
There was a problem hiding this comment.
This is cool! Why endo1 instead of endo?
There was a problem hiding this comment.
cuz it doesn't have all of the endo modules; just the ones needed by this 1st use case
but that reminds me... I should get input from endo folks such as @kriskowal
dckc
commented
Feb 15, 2024
| E.when( | ||
| Promise.all([E(brand).getAllegedName(), E(brand).getDisplayInfo()]), | ||
| ([allegedName, displayInfo]) => | ||
| init(brand, harden({ allegedName, displayInfo })), |
There was a problem hiding this comment.
I think this is goofy; I don't think this collection is keyed by brand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #59
We produce a new
publishBrandInfopower (feat) and use it to reduce the power granted to dapp-offer-up's core eval script (fix).Along the way, we likewise make
makeMarshalavailable via the promise space (perhaps should be its own feat?).Testing Considerations
Until we have something like #46 , I hope reviewers will do a bit of manual testing.