Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using/Teaching zone.exo instead of Far #89

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

amessbee
Copy link
Contributor

@amessbee amessbee commented Aug 6, 2024

This adds code to contract file (and related deps to package.json) to use zone.exo to replace Far. Note that this is only for teaching purpose at the moment and does not make resulting contract upgradable because zone and baggage are created inside start function. The upgradability will require changing start signature which I am avoiding at the moment.

Ref(s):
Agoric/documentation#1033

@amessbee amessbee requested review from erights and dckc August 6, 2024 12:18
@amessbee
Copy link
Contributor Author

amessbee commented Aug 6, 2024

This can't be merged until #78 due to node version requirement for zone. @dckc

Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

baggage is the 3rd arg of start. Let's go ahead and do it that way. I think it simplifies things considerably.

I'm not confident that mixing u16 and u12 dependencies is reliable.

contract/src/offer-up.contract.js Outdated Show resolved Hide resolved
contract/src/offer-up.contract.js Outdated Show resolved Hide resolved
contract/src/offer-up.contract.js Outdated Show resolved Hide resolved
"@agoric/zoe": "^0.26.3-u12.0",
"@agoric/zone": "^0.3.0-u16.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What impact does this have on the contract bundle size? Does it introduce duplicate dependencies?

Other dependencies in this dapp (zoe, ertp) look like they're from u12. IME, mixing u12 and u16 is asking for trouble.

I know dapp-agoric-basics uses u14: Agoric/dapp-agoric-basics@817bc8a

Are you familiar with the fragility of dependency versions?

It looks like @Jovonni managed to use u16 in dapp-orchestration-basics, though it took some troubleshooting. See item 9 in particular.

contract/src/offer-up.contract.js Show resolved Hide resolved
contract/src/offer-up.contract.js Outdated Show resolved Hide resolved
contract/package.json Outdated Show resolved Hide resolved
@dckc
Copy link
Member

dckc commented Aug 7, 2024

I gather recent symptoms include a problem when starting the ui: a blank page and a console error:

tame-console.js:159  TypeError: Cannot read properties of undefined (reading 'subscribeAfter')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants