fix: fix asset selector dialog #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsiegart
force-pushed
the
fix-asset-selector
branch
from
98fb482 to
dc5f9a9
Compare
Deploying with
|
| Latest commit: |
dc5f9a9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bf499dd4.dapp-psm.pages.dev |
| Branch Preview URL: | https://fix-asset-selector.dapp-psm.pages.dev |
turadg
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #100
Also fixes issue on mobile where dialog was being cut off on the top and bottom (see screenshot). Both of these issues were because the dialog was too deeply nested in the component tree and the positioning was behaving unexpectedly as a result. Also removed some unnecessary prop drilling in favor of
useAtomBefore
After