Faucet Polling in E2E Tests #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying dapp-psm with
|
| Latest commit: |
266b099
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a846ad2a.dapp-psm.pages.dev |
| Branch Preview URL: | https://usman-faucet-polling.dapp-psm.pages.dev |
|
Cloudflare deployment logs are available here |
frazarshad
reviewed
Sep 11, 2024
| cy.request({ | ||
| method: 'POST', | ||
| url: networkPhrases.faucetUrl, |
There was a problem hiding this comment.
nit: i think its safe to remove faucetUrl from networkPhrases now
Muneeb147
reviewed
Sep 11, 2024
| const { transactionStatus } = resp.body; | ||
| if (transactionStatus === TRANSACTION_STATUS.NOT_FOUND) | ||
| // eslint-disable-next-line cypress/no-unnecessary-waiting | ||
| return cy.wait(2000).then(() => getStatus(txHash)); |
There was a problem hiding this comment.
Do we have in general timeout limit on our tests? Thinking of a case when we are getting consistent NOT_FOUND for some unexpected reason.
There was a problem hiding this comment.
Yes there is a maximum timeout limit of 30 seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated test to poll for transaction completion
Successful run on Emerynet:
https://github.com/Agoric/dapp-psm/actions/runs/10792624611/job/29932687814