-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created how-to-use-ui-kit explainer #1035
Conversation
Explainer for getting started with `ui-kit`
Deploying documentation with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops... I've got some comments pending. I hope they're not outdated...
} | ||
``` | ||
|
||
### Using a Custom Signer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is using a custom signer required? If not, maybe demote it to after "Executing Offers"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure. Is this a question for @samsiegart?
Just skipping through this PR, it seems to have overlap with various READMEs in ui-kit How do we maintain this going forward? And who does the responsibility of updating docs fall on? Does this mean every time @samsiegart add a new ui-component to ui-kit repo, he'd need to also update the |
Good question @LuqiPan, would love to get @sufyaankhan's thoughts on who owns keeping docs up to date as we go. As it stands today, if an engineer creates a new component are they the one responsible for documenting it in the repo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is a new page, this PR should add it to the navigation (nav.js and/or config.mjs)
@sufyaankhan - Where should this go on the navigation? |
Link to ui-tookit in Building Client Dapps (https://docs.agoric.com/guides/getting-started/contract-rpc.html) instead of stand-alone doc |
Explainer for getting started with
ui-kit