Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad link in core-eval proposal section #1171

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

amessbee
Copy link
Contributor

Contract Installation link in https://docs.agoric.com/guides/coreeval/proposal.html
points to:
https://docs.agoric.com/guides/zoe/#contract-installation

There is no discussion about contract installation on that page. It seems that intended page with the
relevant section is: https://docs.agoric.com/guides/zoe/contract-walkthru.html

I am fixing the link.

@amessbee amessbee requested a review from Jovonni August 13, 2024 03:13
Copy link

cloudflare-workers-and-pages bot commented Aug 13, 2024

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 36f28e6
Status: ✅  Deploy successful!
Preview URL: https://7dc6c27b.documentation-7tp.pages.dev
Branch Preview URL: https://ms-remove-bad-link.documentation-7tp.pages.dev

View logs

Copy link

Cloudflare deployment logs are available here

@amessbee amessbee requested a review from mujahidkay October 1, 2024 13:47
@amessbee amessbee marked this pull request as ready for review October 1, 2024 13:47
@amessbee amessbee self-assigned this Oct 1, 2024
Copy link
Member

@mujahidkay mujahidkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also fix it on core eval page main/guides/coreeval/index.md ?

@amessbee amessbee force-pushed the ms/remove-bad-link branch from a960ce6 to 36f28e6 Compare October 2, 2024 07:10
@amessbee
Copy link
Contributor Author

amessbee commented Oct 2, 2024

@mujahidkay good catch. Fixed that too.

@amessbee amessbee merged commit b55fc99 into main Oct 2, 2024
6 checks passed
@amessbee amessbee deleted the ms/remove-bad-link branch October 2, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants