Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: getPayout() throws if there's no payment for the keyword #1262

Merged
merged 2 commits into from
Jan 4, 2025

Conversation

Chris-Hibbert
Copy link
Collaborator

@Chris-Hibbert Chris-Hibbert commented Jan 3, 2025

Issue 8610 pointed out that E(zoeSeat).getPayout('foo'); returned undefined when the keyword was unknown, while the types claimed that it always returned a Payment.

10738 changed Zoe to throw if the Payment didn't exist. This PR updates the documentation to mention that error.

@Chris-Hibbert Chris-Hibbert self-assigned this Jan 3, 2025
@Chris-Hibbert Chris-Hibbert requested a review from turadg January 3, 2025 22:58
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't hurt but seems to me like a detail we should leave to docs generated from source code

Copy link

cloudflare-workers-and-pages bot commented Jan 3, 2025

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1b20193
Status: ✅  Deploy successful!
Preview URL: https://9adb1186.documentation-7tp.pages.dev
Branch Preview URL: https://10738-getpayoutthrows.documentation-7tp.pages.dev

View logs

Copy link

github-actions bot commented Jan 3, 2025

Cloudflare deployment logs are available here

@Chris-Hibbert Chris-Hibbert merged commit 8acee93 into main Jan 4, 2025
6 checks passed
@Chris-Hibbert Chris-Hibbert deleted the 10738-getPayoutThrows branch January 4, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants