ci(mergify): consolidate queue_conditions
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jun 14, 2024
`queue_conditions` prevent a PR from entering the merge queue. What we really want is `merge_conditions`, which allows PRs to embark on the merge train while integration tests are still running, and only actually merge when the tests are successful. Also, we can use `queue_conditions` to consolidate and clean up the condition logic in our `pull_request_rules`. https://docs.mergify.com/merge-queue/setup/#configuring-the-merge-queue-rules Tested successfully in Agoric/mergify-experiements#13
mhofman
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jun 20, 2024
`queue_conditions` prevent a PR from entering the merge queue. What we really want is `merge_conditions`, which allows PRs to embark on the merge train while integration tests are still running, and only actually merge when the tests are successful. Also, we can use `queue_conditions` to consolidate and clean up the condition logic in our `pull_request_rules`. https://docs.mergify.com/merge-queue/setup/#configuring-the-merge-queue-rules Tested successfully in Agoric/mergify-experiements#13
mhofman
pushed a commit
to Agoric/agoric-sdk
that referenced
this pull request
Jun 22, 2024
`queue_conditions` prevent a PR from entering the merge queue. What we really want is `merge_conditions`, which allows PRs to embark on the merge train while integration tests are still running, and only actually merge when the tests are successful. Also, we can use `queue_conditions` to consolidate and clean up the condition logic in our `pull_request_rules`. https://docs.mergify.com/merge-queue/setup/#configuring-the-merge-queue-rules Tested successfully in Agoric/mergify-experiements#13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper separation of
queue_conditionsandmerge_conditions.