Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add the German translation file. #1197

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

DavidKlempfner
Copy link

No description provided.

Copy link

gitguardian bot commented Mar 4, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic Password 172e287 src/Aguacongas.TheIdServer.Duende/Localization-de.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@AppVeyorBot
Copy link

@aguacongas
Copy link
Member

#1197

@aguacongas aguacongas changed the title Added the German translation file. style: add the German translation file. Mar 4, 2024
Copy link
Member

@aguacongas aguacongas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the Aguacongas.TheIdServer.Duende.csproj project file so this file will be deployed:

PreserveNewest PreserveNewest

"value": "Entweder eine Metadaten- oder Redirect-URI muss festgelegt sein."
},
{
"key": "Either a metadata or redirect URI must be set.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update this key with : "Either a metadata URI or a X509Certificate secret must be set."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I do the same in the -fr.json file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did, thx

@AppVeyorBot
Copy link

@aguacongas aguacongas merged commit 76a71d5 into Aguafrommars:master Mar 6, 2024
6 of 9 checks passed
@aguacongas
Copy link
Member

#567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants