Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default voice language from args if not provided #2728

Closed
wants to merge 1 commit into from

Conversation

preynal
Copy link
Contributor

@preynal preynal commented Dec 30, 2024

when passing the voice-language arg from .aider.conf or an env variable it wasn't being used and is always set to None, so the whisper model would translate a voice with an accent to it's original language

@paul-gauthier
Copy link
Collaborator

Thanks for your interest in aider and for filing this PR. Good catch on this bug. I fixed it a different way.

The change is available in the main branch. You can get it by installing the latest version from github:

aider --install-main-branch

# or...

python -m pip install --upgrade --upgrade-strategy only-if-needed git+https://github.com/Aider-AI/aider.git

If you have a chance to try it, let me know if it works better for you.

@preynal preynal deleted the fix_voice_language_arg branch December 30, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants