Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ESP32 arduino 3.0x patches from upstream #15

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Conversation

willmmiles
Copy link
Collaborator

Import the Arduino 3.0.0 support patches from upstream. While WLED may not be looking at updating in the near future, we can keep our repo in sync.

@willmmiles willmmiles merged commit 171c740 into master Aug 5, 2024
0 of 6 checks passed
@willmmiles willmmiles deleted the arduino-3 branch August 5, 2024 13:32
@DRSDavidSoft
Copy link

I wish you could also consider incorporatng mathieucarbou's updates. It has significantly enhanced the original library:
https://github.com/mathieucarbou/ESPAsyncWebServer

This is the only fork with an excellent continuation of the original lib. If WLED's fork could be rebased on it, it would greatly improve the development experience moving forward!

@willmmiles
Copy link
Collaborator Author

I wish you could also consider incorporatng mathieucarbou's updates. It has significantly enhanced the original library: https://github.com/mathieucarbou/ESPAsyncWebServer

This is the only fork with an excellent continuation of the original lib. If WLED's fork could be rebased on it, it would greatly improve the development experience moving forward!

Is there a specific feature or feature set you're looking for? I haven't tested that fork specifically, but I did independently try doing some of the "custom structure to STL" replacements there, and saw a substantial increase in the code size on ESP32 -- enough that I ultimately backed out those changes and patched up the local abstractions instead. Unfortunately code size is the number one limited resource for the WLED project these days.

@DRSDavidSoft
Copy link

@willmmiles I understand, I was mostly looking for the optimizations such as mathieucarbou#55 regarding strings (you can read more about it at mathieucarbou#54), as well as some recent new features that is super useful when developing a custom interface for WLED or delivering it to the user in, when the bundle size is larger.

I didn't consider the increase in code size when I suggested this. With that being said, I believe the idealistic approach is to do the rebase anyway, and utilize flags to disable parts that aren't needed to decrease code size. Although this will take development costs and is not a priority. I also support taking WLED patches there if it can benefit the library as a whole, especially ones related to the handling of WebSocket.

For the time being, may I suggest opening the issues tab? That way if some important features are missing in this fork, we can simply create a new issue to coordinate adding it in a way that wouldn't cause substantial code size increase.

I hope in the future, the branches for this lib would be streamlined. There are some quality patches in both repos and it'd be exciting if they get mainlined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants