Skip to content

Commit

Permalink
Fix for missing WLED_NUM_PINS check
Browse files Browse the repository at this point in the history
  • Loading branch information
blazoncek committed Sep 15, 2024
1 parent e34f179 commit d5777b7
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions wled00/FX_fcn.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1262,7 +1262,8 @@ void WS2812FX::finalizeInit() {
DEBUG_PRINTLN(F("No available pins left! Can't configure output."));
return;
}
// is the newly assigned pin already defined? try next in line until there are no clashes
// is the newly assigned pin already defined or used previously?
// try next in line until there are no clashes or we run out of pins
bool clash;
do {
clash = false;
Expand All @@ -1275,14 +1276,16 @@ void WS2812FX::finalizeInit() {
}
// We already have a clash on current bus, no point checking next buses
if (!clash) {
// check for conflicts on next buses
for (unsigned k = pinsIndex + busPins; k < defNumPins; k++) {
if (defDataPins[k] == defPin[j]) {
// check for conflicts in defined pins
for (const auto &pin : defDataPins) {
if (pin == defPin[j]) {
clash = true;
break;
}
}
}
if (clash) defPin[j]++;
if (defPin[j] >= WLED_NUM_PINS) break;
} while (clash);
}
}
Expand Down

0 comments on commit d5777b7

Please sign in to comment.