Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Olimex ESP32-GATEWAY #3421

Closed
wants to merge 0 commits into from
Closed

Conversation

bikerglen
Copy link

I added Ethernet support for the Olimex ESP32-GATEWAY board. I tested this with a RevG version of that board. The only difference between the ESP32-POE board and the ESP32-GATEWAY board is the PHY power pin. It's on pin 12 of the PoE board and pin 5 on the gateway board. I used npm to rebuild the html header files and checked those into this commit / pull request since the settings_wifi.htm file was modified to include the ESP32-GATEWAY option.

@bikerglen bikerglen changed the title Add support for Olixex ESP32-GATEWAY Add support for Olimex ESP32-GATEWAY Oct 4, 2023
@bikerglen
Copy link
Author

And of course I have a typo in the commit message. Should be Olimex rather than Olixex.

@blazoncek
Copy link
Collaborator

Thanks, but please remove all unnecessary files modified by npm.

@bikerglen
Copy link
Author

If I understand correctly, you would like me to keep wled00/html_settings.h in the commit and pull request since that's required to add ESP32_GATEWAY to the html wifi settings page but remove the rest of the html_*.h files from the commit and pull request. Is that correct?

@blazoncek
Copy link
Collaborator

Yes.

@bikerglen
Copy link
Author

Should be done now.

@blazoncek
Copy link
Collaborator

Please, do not force-push changes next time. Do a normal commit and push.

@bikerglen
Copy link
Author

I don't do a lot of complex git tasks. Will what I've done work or should I delete my fork and pull request and start over?

@blazoncek
Copy link
Collaborator

It will work, just don't force push in the future.

@blazoncek
Copy link
Collaborator

https://github.com/Aircoookie/WLED/wiki/How-to-properly-submit-a-PR

@softhack007 softhack007 added this to the 0.14.1 candidate milestone Oct 5, 2023
@softhack007 softhack007 added the board request PR adding support for a specific board. label Jan 3, 2024
@blazoncek
Copy link
Collaborator

Hi. Could you re-base this PR for 0_15 branch and then we can merge it?

@blazoncek blazoncek added the waiting for feedback addition information needed to better understand the issue label May 22, 2024
@bikerglen bikerglen closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board request PR adding support for a specific board. waiting for feedback addition information needed to better understand the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants