-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End oappend v2 #4152
Merged
Merged
End oappend v2 #4152
Commits on Sep 18, 2024
-
handleFileRead: Skip duplicate FS check
Since we validate the file existence ourselves, no need to have AsyncWebServer do it again.
Configuration menu - View commit details
-
Copy full SHA for d4268ba - Browse repository at this point
Copy the full SHA d4268baView commit details -
tools: Add all_xml fetch script
Useful for checking that I haven't broken anything.
Configuration menu - View commit details
-
Copy full SHA for 1346eb4 - Browse repository at this point
Copy the full SHA 1346eb4View commit details
Commits on Sep 19, 2024
-
Remove the large stack buffer as we're just going to copy it in to a heap buffer anyways. Later we can refine the length estimation or use a rope-style dynamic data structure like DynamicBufferList.
Configuration menu - View commit details
-
Copy full SHA for 32f9616 - Browse repository at this point
Copy the full SHA 32f9616View commit details -
Usermod: Implement shim for oappend
Use a static Print* to transform old oappend calls to print calls.
Configuration menu - View commit details
-
Copy full SHA for 16f61ea - Browse repository at this point
Copy the full SHA 16f61eaView commit details -
Reduce the total number of calls by using printf_P and skipping atoi().
Configuration menu - View commit details
-
Copy full SHA for 4ef583c - Browse repository at this point
Copy the full SHA 4ef583cView commit details -
Use named functions to describe what's being printed.
Configuration menu - View commit details
-
Copy full SHA for 7114874 - Browse repository at this point
Copy the full SHA 7114874View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae1df20 - Browse repository at this point
Copy the full SHA ae1df20View commit details -
Rename destination for getSettingsJS
Use a name that makes it a bit clearer what the output is. The new name is applied consistently through most uses. Usermods are not yet updated.
3Configuration menu - View commit details
-
Copy full SHA for 45cf900 - Browse repository at this point
Copy the full SHA 45cf900View commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3f3c986 - Browse repository at this point
Copy the full SHA 3f3c986View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.