feat: Add Validation for PK Mode Against PK Fields and Unit Tests #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joel-hanson
force-pushed
the
validation-pk-mode
branch
from
a79a78f
to
56b5e7e
Compare
C0urante
reviewed
Jun 29, 2024
|
|
||
| final Config config = new JdbcSinkConnector().validate(props); | ||
|
|
||
| assertFalse(config.configValues().stream().allMatch(cv -> cv.errorMessages().size() > 0)); |
There was a problem hiding this comment.
This asserts that there's at least one property that didn't have an error message. I'm guessing we actually want to assert that no properties have error messages?
Suggested change
| assertFalse(config.configValues().stream().allMatch(cv -> cv.errorMessages().size() > 0)); | |
| assertFalse(config.configValues().stream().anyMatch(cv -> cv.errorMessages().size() > 0)); |
C0urante
reviewed
Jun 29, 2024
There was a problem hiding this comment.
Thanks @Joel-hanson, this looks fantastic! Only have one small comment about a test case, everything else LGTM. If the suggestion makes sense, you can just amend the single current commit and force push, then we can merge.
Signed-off-by: Joel Hanson <[email protected]> Signed-off-by: Joel Hanson <[email protected]>
Joel-hanson
force-pushed
the
validation-pk-mode
branch
from
56b5e7e
to
fa39b97
Compare
|
@C0urante you are right and I have added in that change. |
C0urante
approved these changes
Jul 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces validation logic for the primary key mode (
pk.mode) against the primary key fields (pk.fields) in theJdbcSinkConfigclass, ensuring that the configurations adhere to the documented requirements. Additionally, unit tests have been added to verify the correctness of the validation logic.Changes:
validatePKModeAgainstPKFieldsmethod to validate the primary key mode against the primary key fields.pk.modeandpk.fieldsto ensure configurations are valid according to the documentation.