Skip to content

Commit

Permalink
chore: call make install before docker build
Browse files Browse the repository at this point in the history
  • Loading branch information
jjaakola-aiven committed Sep 26, 2024
1 parent a5e1855 commit 4f6f48b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
1 change: 1 addition & 0 deletions .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
!src
!requirements/*.txt
!README.rst
!LICENSE
!pyproject.toml
!container/start.sh
!container/healthcheck.py
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/container-smoke-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,7 @@ jobs:
fetch-depth: 0

- name: Install requirements
run: |
python -m venv venv
source ./venv/bin/activate
pip install .
run: make install

- name: Resolve Karapace version
run: |
Expand All @@ -33,7 +30,7 @@ jobs:
run: docker build --build-arg KARAPACE_VERSION=${{ env.KARAPACE_VERSION }} --file=container/Dockerfile .

- name: Run container
run: docker compose --file=container/compose.yml up --build --wait --detach
run: docker-compose --file=container/compose.yml up --build

- name: Smoke test registry
run: bin/smoke-test-registry.sh
Expand Down
2 changes: 1 addition & 1 deletion container/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ RUN --mount=type=cache,target=/root/.cache/pip \
else \
PRETEND_VERSION=$KARAPACE_VERSION; \
fi; \
SETUPTOOLS_SCM_PRETEND_VERSION=$PRETEND_VERSION python3 -m pip install --no-deps .
SETUPTOOLS_SCM_PRETEND_VERSION=$PRETEND_VERSION python3 -m pip install -v --no-deps .

# Karapace image, i.e. production.
FROM python:3.10.11-slim-bullseye AS karapace
Expand Down

0 comments on commit 4f6f48b

Please sign in to comment.