Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly set retries to 0 #715

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

eliax1996
Copy link
Contributor

Currently in the backup tool we leave implicitly the setting about the retries.
This (if the default value change) could lead to duplication of messages in the restore of a topic.

@eliax1996 eliax1996 requested review from a team as code owners September 15, 2023 11:58
@eliax1996 eliax1996 force-pushed the eliax1996/explicitly-set-producer-retries-to-0 branch from 39f3201 to 64b6f3e Compare September 15, 2023 12:03
Copy link
Contributor

@tvainika tvainika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove runtime/.gitignore. It is there for convenience.

@eliax1996 eliax1996 force-pushed the eliax1996/explicitly-set-producer-retries-to-0 branch from 64b6f3e to f9605df Compare September 15, 2023 15:08
@eliax1996
Copy link
Contributor Author

Thanks for the catch @tvainika, don't know why I've committed it :) and also I don't know how I've deleted it :P

@tvainika tvainika merged commit 0e93408 into main Sep 15, 2023
8 checks passed
@tvainika tvainika deleted the eliax1996/explicitly-set-producer-retries-to-0 branch September 15, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants