Replace sync Kafka consumers with confluent_kafka one #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ca4412e.
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_consumers
branch
2 times, most recently
from
480822a to
80f07dc
Compare
|
@matyaskuti Could you comment the exact spot in the PR for the spot where the bug was? |
|
@jjaakola-aiven I updated the description with the location. After a short discussion with @aiven-anton I'll attempt to add a test that reveals this issue through the backups code as well. |
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_consumers
branch
from
80f07dc to
c4549d0
Compare
aiven-anton
previously requested changes
Jan 11, 2024
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_consumers
branch
from
c4549d0 to
a30608f
Compare
When instantiating the consumer we already a subscribe to the topic that is to be backed up (ie. __schemas). Using assign on top of that causes problems - once the assignment actually takes effect, the consumer starts to consume from the beginning, ultimately resulting in an `InconsistentOffset` error. The default subscribe is enough at the moment, as we do not support backing up a multi-partition topic.
matyaskuti
force-pushed
the
matyaskuti/confluent_kafka_consumers
branch
from
a30608f to
2c03ba0
Compare
aiven-anton
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
karapace/backup/api.pyL533 removed, see the second commit in this PRWhy this way
consumer.assignafterconsumer.subscribeis not supposed to be done (further tests and guards will be introduced in a later PR which adds enriched functionality to consumers)