Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unknown Kafka errors with _RESOLVE error code #968

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

keejon
Copy link
Contributor

@keejon keejon commented Sep 30, 2024

translates _RESOLVE error code to KafkaUnavailableError. Also don't log KafkaUnavailableError as unexpected error.

Also fixes check for new project source layout in schema_tool.py

About this change - What it does

References: #xxxxx

Why this way

Also don't log KafkaUnavailableError as unexpected error
@keejon keejon force-pushed the keejon/fix-unknown-errors branch from 2c13567 to c01b025 Compare September 30, 2024 13:41
Copy link

github-actions bot commented Sep 30, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/karapace
  schema_reader.py 255
  src/karapace/backup/backends/v3
  schema_tool.py 89
  src/karapace/kafka
  common.py 63
Project Total  

This report was generated by python-coverage-comment-action

@keejon keejon marked this pull request as ready for review September 30, 2024 15:28
@keejon keejon requested review from a team as code owners September 30, 2024 15:28
@jjaakola-aiven jjaakola-aiven merged commit cc65f6a into main Oct 1, 2024
10 checks passed
@jjaakola-aiven jjaakola-aiven deleted the keejon/fix-unknown-errors branch October 1, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants