chore: fix schema tool source layout check return code handling #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this be possible to remove now that the change is made? We can always assume src layout now? |
jjaakola-aiven
force-pushed
the
jjaakola-aiven-fix-schema-tool-returncode-handling
branch
from
71a04ef to
5d53ded
Compare
jjaakola-aiven
force-pushed
the
jjaakola-aiven-fix-schema-tool-returncode-handling
branch
from
5d53ded to
a1a5f39
Compare
aiven-anton
approved these changes
Oct 16, 2024
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
Closing, #978 removes the source layout checking. After 4.0.0 the assumption is the source layout. Last release with non-source layout is 3.16.0. |
jjaakola-aiven
deleted the
jjaakola-aiven-fix-schema-tool-returncode-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
References: #xxxxx
Why this way