Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate REST Proxy subscription param types #981

Conversation

jjaakola-aiven
Copy link
Contributor

About this change - What it does

References: #xxxxx

Why this way

@jjaakola-aiven jjaakola-aiven requested review from a team as code owners October 17, 2024 06:56
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/karapace/kafka_rest_apis
  consumer_manager.py
Project Total  

This report was generated by python-coverage-comment-action

@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-validate-rest-proxy-subscription-param-types branch from e1d2f48 to 7f01de7 Compare October 17, 2024 07:23
Copy link
Contributor

@davide-armand davide-armand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a comment

tests/integration/test_rest_consumer.py Outdated Show resolved Hide resolved
@jjaakola-aiven jjaakola-aiven force-pushed the jjaakola-aiven-validate-rest-proxy-subscription-param-types branch from 7f01de7 to 4c41189 Compare October 17, 2024 09:07
@davide-armand davide-armand merged commit 60b5db6 into main Oct 17, 2024
9 checks passed
@davide-armand davide-armand deleted the jjaakola-aiven-validate-rest-proxy-subscription-param-types branch October 17, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants