Avro references poc implementation using avro lib #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using avro unions, use avro lib (function `make_avsc_object()`) to merge together reference schemas and main schema. This is just a proof of concept, it does not support indirect references for example (schema1 --> schema2 --> schema3).
davide-armand
commented
Oct 31, 2024
| SCHEMA_PERSON_AGE_INT_LONG = { | ||
| "type": "record", | ||
| "name": "Person", | ||
| "namespace": "com.netapp", | ||
| "fields": [ | ||
| {"name": "name", "type": "string"}, | ||
| {"name": "age", "type": "long"}, | ||
| {"name": "address", "type": "Address"}, | ||
| # {"name": "address", "type": "Address"}, |
There was a problem hiding this comment.
Commented out indirect refs since they don't work, so that other tests can be executed
There was a problem hiding this comment.
Maybe we don't need to support indirect refs, it's unclear if Schema Registry supports them
|
Closing this as it was just a proof of concept |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept for implementing Avro reference using Avro python library.
I used the following PR (implementation using unions) as the base: #926
What works:
What does not work: