-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(coral): Topic documentation - show empty state and preview #1395
Conversation
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me except for my bugbear, but I think we should have comments and/or documentation somewhere about the reponsabilities of react-markdown
and the rehype-raw
plugins, so the flow of html -> string -> markdown -> string -> html is crystal clear :o
Thank you ^^
coral/src/app/features/topics/details/documentation/TopicDocumentation.tsx
Outdated
Show resolved
Hide resolved
Yes! I would add that in the next PR though, where I add the "add/edit" functionality, because I'm not 1000% sure now how the process will look like in detail (like, which plugins etc) in the end. |
Yes, the documentation should probably be written last ^^ |
Signed-off-by: Mirjam Aulbach <[email protected]>
Signed-off-by: Mirjam Aulbach <[email protected]>
5130972
to
2b53795
Compare
About this change - What it does
Technical background
Approach general:
Since the angular app still uses html to show docs and our users may have saved documentation as html, we decided to go continue with the approach to save the documentation as stringyfied html (at least for now). We still will offer a markdown editor to users. The formatting between html and markdown will happen in frontend (remarkjs together with rehype offers good solutions for that). This provides a more safe input option for us and keeps the door open to change everything to markdown at some point.
Styles
We need to add some overrides for styles. For the html elements in documentation the global styles from DS are applied, which means that there are styles on elements that are reseted to be styled with classes etc (which the html in documentation does not have).
After sync with Mustafa I added styles for basic typography elements (where needed). This should cover most cases for user already, if not all. We can update that if needed.
Recording
recording-documentation.mov
Relates to #1298