-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for snapshot metrics #295
base: main
Are you sure you want to change the base?
Conversation
8c581c8
to
9903692
Compare
FYI, to get rid of the Developer Certificate of Origin (DCO) check failure you need to sign all commits with This will add a specific line into the commit message containing your signature with your email. See any other commit message in this repository for example of the text. You can create the signature manually in the commit message as well but using (Use of git |
Signed-off-by: Smit Patel <[email protected]>
@lukas-vlcek signed off the commit, please review |
745948e
to
e3cd706
Compare
@lukas-vlcek I have added integration test and updated the README also, PTAL |
72092d2
to
a000692
Compare
@lukas-vlcek can you please help review this PR? |
@patelsmit32123 Sorry, I was on 🌴 last week. I will do it this week. |
Signed-off-by: Smit Patel <[email protected]>
@patelsmit32123 Thanks a lot for your patience! I am really sorry for the delay in processing this.
|
@lukas-vlcek i am not able to see your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I am proposing some changes and enhancements. Let me know if anything is not clear.
Overall, great contribution, thanks for the effort.
src/main/java/org/opensearch/action/NodePrometheusMetricsResponse.java
Outdated
Show resolved
Hide resolved
@patelsmit32123 Can you see my comments now? |
Signed-off-by: Smit Patel <[email protected]>
@lukas-vlcek thanks for the review, resolved all comments |
@lukas-vlcek is there anything else needed to be done for this PR? |
@patelsmit32123 I think it is ready. I am trying to implement #315 now (your PR will benefit from it) but if a new release is needed before BWC tests are ready I will just go ahead and merge it to make it part of the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
#165 Following the issue opened by ginkel, this PR adds the required changes for basic support for snapshot related metrics, starting with snapshot_age. More snapshot related metrics can be added on top of this changes.
DCO stands for Developer Certificate of Origin and it is your declaration that your contribution is correctly attributed and licensed. Please read more about how to attach DCO to your commits here (spoiler alert: in most cases it is as simple as using
-s
option when doinggit commit
).Please be aware that commits without DCO will cause failure of PR CI workflow and can not be merged.