Refactor chunk cache #443
Draft
Refactor chunk cache #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanyu
force-pushed
the
ivanyu/refactor-cache
branch
from
0487867 to
301502b
Compare
ivanyu
commented
Nov 10, 2023
There was a problem hiding this comment.
These tests were moved to AbstractChunkCacheTest and the prefetching tests, to DefaultChunkManagerTest.
ivanyu
force-pushed
the
ivanyu/refactor-cache
branch
from
301502b to
7c01742
Compare
ivanyu
commented
Nov 10, 2023
| .compute(chunkKey, (key, val) -> { | ||
| if (val == null) { | ||
| statsCounter.recordMiss(); | ||
| // TODO do not put a failed future into the cache |
There was a problem hiding this comment.
This is a pre-existing problem, decided not to handle it in this PR
ivanyu
commented
Nov 10, 2023
Comment on lines
+99
to
+100
| // TODO do some logging if error | ||
| // TODO do not put a failed future into the cache |
There was a problem hiding this comment.
These are pre-existing problems, decided not to handle them in this PR
ivanyu
force-pushed
the
ivanyu/refactor-cache
branch
from
7c01742 to
eb55757
Compare
ivanyu
commented
Nov 10, 2023
|
|
||
| assertThat(chunkManager.getChunk(OBJECT_KEY, manifest, 0)).hasBinaryContent(TEST_CHUNK_CONTENT); | ||
| verify(storage).fetch(OBJECT_KEY, chunkIndex.chunks().get(0).range()); | ||
| } | ||
|
|
||
| @Nested | ||
| class PrefetchTests { |
There was a problem hiding this comment.
From ChunkCacheTest.java
ivanyu
force-pushed
the
ivanyu/refactor-cache
branch
from
eb55757 to
1b83e36
Compare
ivanyu
commented
Nov 10, 2023
There was a problem hiding this comment.
From ChunkCacheTest.java
Before, the chunk cache(s) was a wrapper over `DefaultChunkManager`. In some situations, this is not very convenient and also the cache has more responsibilities than it should (like prefetching). This commit refactors the cache to be a pluggable mechanism in the chunk manager.
ivanyu
force-pushed
the
ivanyu/refactor-cache
branch
from
1b83e36 to
b1ae9a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the chunk cache(s) was a wrapper over
DefaultChunkManager. In some situations, this is not very convenient and also the cache has more responsibilities than it should (like prefetching). This commit refactors the cache to be a pluggable mechanism in the chunk manager.