Allocate direct buffers for multipart upload #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopuskh3
changed the title
|
I think this feature is good. |
rsharan-dd
suggested changes
Jun 6, 2024
storage/s3/src/main/java/io/aiven/kafka/tieredstorage/storage/s3/S3Storage.java
Outdated
Show resolved
Hide resolved
storage/s3/src/main/java/io/aiven/kafka/tieredstorage/storage/s3/S3Storage.java
Outdated
Show resolved
Hide resolved
storage/s3/src/main/java/io/aiven/kafka/tieredstorage/storage/s3/S3Storage.java
Outdated
Show resolved
Hide resolved
storage/s3/src/main/java/io/aiven/kafka/tieredstorage/storage/s3/S3StorageConfig.java
Outdated
Show resolved
Hide resolved
dopuskh3
force-pushed
the
francois.visconte/allocate-direct-buffers
branch
2 times, most recently
from
8ffac2f to
05ef2ed
Compare
|
@jeqo fixed tests, PTAL |
Allow to allocate multipart upload buffers as direct buffer rather than on the heap. We try to set a pretty large multipart upload part size on cluster to optimize throughput and reduce S3 requests. At the same time, we try to keep kafka JVM heap size contained on most kafka installation in order to leave as much memory as possible for the page cache. As a matter of example, we will use 4GB heap size on machines with 64GB available memory. The consequence of using pretty large multipart upload size on contained JVM heap size is that we can pretty easily run out of heap size if we suddenly have to upload many segments to tiered storage. The strategy we propose is to allocate multipart buffer in direct memory so that we can more easily configure direct buffer budget.
dopuskh3
force-pushed
the
francois.visconte/allocate-direct-buffers
branch
from
05ef2ed to
9fcdda2
Compare
jeqo
reviewed
Aug 8, 2024
| @@ -58,6 +58,11 @@ public class S3StorageConfig extends AbstractConfig { | |||
| private static final String S3_MULTIPART_UPLOAD_PART_SIZE_DOC = "Size of parts in bytes to use when uploading. " | |||
| + "All parts but the last one will have this size. " | |||
| + "Valid values: between 5MiB and 2GiB"; | |||
|
|
|||
| public static final String S3_MULTIPART_UPLOAD_DIRECT_BUFFERS_CONFIG = "s3.multipart.upload.direct.buffers"; | |||
There was a problem hiding this comment.
nit:
Suggested change
| public static final String S3_MULTIPART_UPLOAD_DIRECT_BUFFERS_CONFIG = "s3.multipart.upload.direct.buffers"; | |
| public static final String S3_MULTIPART_UPLOAD_BUFFER_ALLOCATION_DIRECT_CONFIG = "s3.multipart.upload.buffer.allocation.direct"; |
| @@ -261,6 +272,10 @@ public Boolean pathStyleAccessEnabled() { | |||
| return getBoolean(S3_PATH_STYLE_ENABLED_CONFIG); | |||
| } | |||
|
|
|||
| public Boolean multipartDirectBuffers() { | |||
There was a problem hiding this comment.
nit:
Suggested change
| public Boolean multipartDirectBuffers() { | |
| public Boolean uploadBufferAllocationDirect() { |
There was a problem hiding this comment.
Could these tests be parametrized to have coverage for the direct allocation?
| @@ -44,12 +44,15 @@ public class S3Storage implements StorageBackend { | |||
| private String bucketName; | |||
| private int partSize; | |||
|
|
|||
| private boolean multipartDirectBuffers; | |||
There was a problem hiding this comment.
nit:
Suggested change
| private boolean multipartDirectBuffers; | |
| private boolean bufferAllocationDirect; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to allocate multipart upload buffers as direct buffer rather than on the heap.
Reasoning
We try to set a pretty large multipart upload part size on cluster to optimize throughput and reduce S3 requests.
At the same time, we try to keep kafka JVM heap size contained on most kafka installation in order to leave as much memory as possible for the page cache. As a matter of example, we will use 4GB heap size on machines with 64GB available memory.
The consequence of using pretty large multipart upload size on contained JVM heap size is that we can pretty easily run out of heap size if we suddenly have to upload many segments to tiered storage.
The strategy we propose is to allocate multipart buffers in direct memory so that we can more easily configure direct buffer budget.
Usage
We introduced
s3.multipart.upload.direct.buffersboolean configuration flag (disabled by default).