Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add some type hints, refactor existing code, update docker to use python 3.10 #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MaertHaekkinen
Copy link
Member

Still needs checking, but added some previously unsaved changes to this PR.
Description to be added here.

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2022

This pull request introduces 2 alerts and fixes 12 when merging 13c79eb into 6f66ead - view on LGTM.com

new alerts:

  • 2 for Variable defined multiple times

fixed alerts:

  • 6 for Testing equality to None
  • 3 for Unused local variable
  • 3 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2022

This pull request introduces 2 alerts and fixes 12 when merging 96dbd70 into 6f66ead - view on LGTM.com

new alerts:

  • 2 for Variable defined multiple times

fixed alerts:

  • 6 for Testing equality to None
  • 3 for Unused local variable
  • 3 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2022

This pull request introduces 4 alerts and fixes 21 when merging e992eba into 6f66ead - view on LGTM.com

new alerts:

  • 2 for Variable defined multiple times
  • 1 for Redundant comparison
  • 1 for Wrong number of arguments in a call

fixed alerts:

  • 6 for Testing equality to None
  • 5 for Unused import
  • 4 for First parameter of a method is not named 'self'
  • 4 for Unused local variable
  • 1 for Module is imported more than once
  • 1 for 'import *' may pollute namespace

@lgtm-com
Copy link

lgtm-com bot commented Nov 4, 2022

This pull request introduces 4 alerts and fixes 21 when merging 46755d8 into 6f66ead - view on LGTM.com

new alerts:

  • 2 for Variable defined multiple times
  • 1 for Redundant comparison
  • 1 for Wrong number of arguments in a call

fixed alerts:

  • 6 for Testing equality to None
  • 5 for Unused import
  • 4 for First parameter of a method is not named 'self'
  • 4 for Unused local variable
  • 1 for Module is imported more than once
  • 1 for 'import *' may pollute namespace

@MaertHaekkinen MaertHaekkinen changed the title refactor Draft: Add some type hints, refactor existing code, update docker to use python 3.10 Nov 4, 2022
@lgtm-com
Copy link

lgtm-com bot commented Nov 4, 2022

This pull request introduces 3 alerts and fixes 22 when merging 2a31d53 into 6f66ead - view on LGTM.com

new alerts:

  • 1 for Redundant comparison
  • 1 for Variable defined multiple times
  • 1 for Wrong number of arguments in a call

fixed alerts:

  • 6 for Testing equality to None
  • 5 for Unused import
  • 4 for First parameter of a method is not named 'self'
  • 4 for Unused local variable
  • 1 for Signature mismatch in overriding method
  • 1 for Module is imported more than once
  • 1 for 'import *' may pollute namespace

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 21 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2022

This pull request introduces 3 alerts and fixes 22 when merging 4c2d6ab into 6f66ead - view on LGTM.com

new alerts:

  • 1 for Redundant comparison
  • 1 for Variable defined multiple times
  • 1 for Wrong number of arguments in a call

fixed alerts:

  • 6 for Testing equality to None
  • 5 for Unused import
  • 4 for First parameter of a method is not named 'self'
  • 4 for Unused local variable
  • 1 for Signature mismatch in overriding method
  • 1 for Module is imported more than once
  • 1 for 'import *' may pollute namespace

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 13 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 10 Security Hotspots
Code Smell A 48 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant