Skip to content

Commit

Permalink
Changed request code for permission in Android (CarnegieTechnologies#9)
Browse files Browse the repository at this point in the history
gallery_saver was using the same request code for storage permission as image_picker for camera,
and it was crashing android app.

CWF-353
  • Loading branch information
jelenalecic authored Aug 6, 2019
1 parent 37c4205 commit 850bb69
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.0.5

* Fix for colliding permission request with image_picker plugin

## 0.0.4

* Return type changed to bool(true for success and false for everything else)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ class GallerySaver internal constructor(private val activity: Activity) : Plugin

companion object {

private const val REQUEST_EXTERNAL_IMAGE_STORAGE_PERMISSION = 2345
private const val REQUEST_EXTERNAL_IMAGE_STORAGE_PERMISSION = 2408

private const val KEY_PATH = "path"
}
Expand Down
1 change: 0 additions & 1 deletion gallery_saver.iml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
<excludeFolder url="file://$MODULE_DIR$/example/ios/.symlinks/plugins/gallery_saver/example/.dart_tool" />
<excludeFolder url="file://$MODULE_DIR$/example/ios/.symlinks/plugins/gallery_saver/example/.pub" />
<excludeFolder url="file://$MODULE_DIR$/example/ios/.symlinks/plugins/gallery_saver/example/build" />
<excludeFolder url="file://$MODULE_DIR$/example/ios/.symlinks/plugins/gallery_saver/example/ios/Flutter/App.framework/flutter_assets/packages" />
<excludeFolder url="file://$MODULE_DIR$/example/ios/Flutter/App.framework/flutter_assets/packages" />
</content>
<orderEntry type="sourceFolder" forTests="false" />
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: gallery_saver
description: Saves images and videos to gallery and photos. Temporary file from camera gets saved to external storage by passing its path to the methods saveImage and saveVideo.
version: 0.0.4
version: 0.0.5
author: Carnegie Technologies d.o.o <[email protected]>
homepage: https://github.com/CarnegieTechnologies/gallery_saver

Expand Down

0 comments on commit 850bb69

Please sign in to comment.