fix: broken scroll behavior #319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itwaze
force-pushed
the
feature/scroll-to-sponsored
branch
from
467a838 to
1dba953
Compare
|
ping @Ajaxy |
korenskoy
reviewed
Dec 14, 2023
itwaze
force-pushed
the
feature/scroll-to-sponsored
branch
from
1dba953 to
27e8e8d
Compare
|
@korenskoy @Ajaxy any updates? |
|
Hey @itwaze thanks for bringing this up. We will check your suggestions. |
|
hi @Ajaxy any updates? soon i will celebrate the anniversary of this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, scrolling does not work for scheduled and pinned messages.
Also, scrolling in normal or select mode with or without sponsored message works partially and the UI looks broken.
This PR contains those corrections.
PS: npm run check passed for touched files.
BEFORE:
BEFORE_ad_channel.mp4
BEFORE_threads_channel_groups_pinned_messages_and_scroll.mp4
AFTER:
AFTER_ad_channel.mp4
AFTER_threads_channel_groups_pinned_messages_and_scroll.mp4