-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User-friendly error message for missing main function #509
Conversation
@Akuli |
@littlewhitecloud Sorry that it took so long for me to start working on this :) I am now quite happy with how it works. C code is reasonably clean, error messages are good, existing and new tests are passing. But I haven't updated the self-hosted compiler. Can you do that? :) |
I need some time to know what changed :) But now I'm a little busy and I will be back to school soon XD |
Ok I just got time but is there |
This loop in found = False
for i = 0; i < self->nfiles; i++:
if strcmp(self->files[i].ast.path, item.path) == 0:
found = True
break |
What's the return type @Akuli ? def find_file(files: FileState*, nfiles: int, path: byte*) -> ?:
for i = 0; i < nfiles; i++:
if strcmp(files[i].ast.path, path) == 0:
return files[i]
return NULL |
I have added a few review comments. Let me know if you need more help :) |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
fix #210