Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Mathlib #511

Merged
merged 7 commits into from
Jul 21, 2024
Merged

Improve Mathlib #511

merged 7 commits into from
Jul 21, 2024

Conversation

littlewhitecloud
Copy link
Contributor

No description provided.

@Akuli
Copy link
Owner

Akuli commented Jul 18, 2024

This looks good, thanks for working on this!

I will "later" figure out why the CI is red. The changes don't look like they should break anything :)

Copy link
Owner

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is why CI fails

@littlewhitecloud littlewhitecloud marked this pull request as ready for review July 21, 2024 06:00
@Akuli
Copy link
Owner

Akuli commented Jul 21, 2024

Thanks for working on this! I pushed a couple commits and I will merge soon.

(If you are wondering why I deleted fmod and fmodf, it is because Jou's % operator already does the same thing. In C, the % operator is only for integers, and it cannot be used with floats or doubles.)

@littlewhitecloud
Copy link
Contributor Author

Thanks for working on this! I pushed a couple commits and I will merge soon.

(If you are wondering why I deleted and , it is because Jou's operator already does the same thing. In C, the operator is only for integers, and it cannot be used with floats or doubles.)fmod``fmodf``%``%

Thanks!

@Akuli Akuli merged commit 6171948 into Akuli:main Jul 21, 2024
24 checks passed
@Akuli Akuli mentioned this pull request Dec 12, 2024
@littlewhitecloud littlewhitecloud deleted the mathimprove branch January 12, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants