-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete toposort dependency #1507
Conversation
Why can't platformdirs be removed? |
Good question. It can be removed, but it would require a few hours of Windows hell. Porcupine only uses As for the windows hell: In |
There's a reason I've decided to cut windows support in all my future projects lol |
Given that xz just happened, I want to minimize Porcupine's dependencies, and I think
toposort
is the only dependency that can be reasonably removed.When I added
toposort
dependency in 2017 (commit c713798), it was because I couldn't figure out how to program it myself. The source code is short, but it looked complicated and I didn't want to copy it. Since then, I have worked with graphs more and the algorithm is now quite obvious to me, so I rewrote it from scratch.