fix: utf8 issue #2113
Open
fix: utf8 issue #2113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi... Just wondering if there was anything I could do to clarify or help things along? If just busy, feel free to ignore... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the time you are putting into AlaSQL!
I believe the following safely fixes #2112 .
Adds a utility to fetch binary data specifically, leaving the old function to retrieve regular UTF8 (non-binary) pages.
Changes an existing
JSON()test to ensure it utilizes the non-binary fetch utility.May break some existing code if they were relying on non-UTF8-encoded text files, but I think this is something that needs fixing.