Fix super-instructions for jumps #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix super-instructions to support bytecode jumps. There were two main problems:
Regarding the
annotateBytecode:, there were 2 for the same super-bytecode, at the end. I added a passDRAnnotateBytecodeInstructionCoalescingTo move all of these instructions at the beginning. I'm not sure about this, I left some comments.When another bytecode jumps to the middle of the super-instruction (to the 2nd bytecode). It is not managing correctly the
fixups. Now the superinstruction is avoided on those cases. I couldn't make it work as I wanted.You can see the changes in
DruidTestRTLCompilerto see the result of these fixes.DruidJIT: pharo-project/pharo-vm#831