chore: permissions refactor

AlanFnz · Dec 6, 2024 · bd5769d · bd5769d
1 parent a2f6d97
commit bd5769d
Show file tree

Hide file tree

Showing 4 changed files with 68 additions and 56 deletions.
diff --git a/src/screens/HomeScreen/components/FloatingButton/hooks/useAudioRecorder.ts b/src/screens/HomeScreen/components/FloatingButton/hooks/useAudioRecorder.ts
@@ -1,43 +1,21 @@
 import { useState } from 'react';
-import { PermissionsAndroid, Platform } from 'react-native';
 import AudioRecorderPlayer from 'react-native-audio-recorder-player';
 
+import { usePermissions } from '@root/src/utils/hooks/usePermissions';
+
 const audioRecorderPlayer = new AudioRecorderPlayer();
 
 export const useAudioRecorder = () => {
   const [isRecording, setIsRecording] = useState(false);
   const [recordingPath, setRecordingPath] = useState<string | null>(null);
+  const { requestAudioPermissions } = usePermissions();
 
   const startRecording = async () => {
     try {
-      // TODO: move this to permissions helper
-      if (Platform.OS === 'android') {
-        try {
-          const grants = await PermissionsAndroid.requestMultiple([
-            PermissionsAndroid.PERMISSIONS.WRITE_EXTERNAL_STORAGE,
-            PermissionsAndroid.PERMISSIONS.READ_EXTERNAL_STORAGE,
-            PermissionsAndroid.PERMISSIONS.RECORD_AUDIO,
-          ]);
-
-          console.log('write external storage', grants);
-
-          if (
-            grants['android.permission.WRITE_EXTERNAL_STORAGE'] ===
-              PermissionsAndroid.RESULTS.GRANTED &&
-            grants['android.permission.READ_EXTERNAL_STORAGE'] ===
-              PermissionsAndroid.RESULTS.GRANTED &&
-            grants['android.permission.RECORD_AUDIO'] ===
-              PermissionsAndroid.RESULTS.GRANTED
-          ) {
-            console.log('Permissions granted');
-          } else {
-            console.log('All required permissions not granted');
-            return;
-          }
-        } catch (err) {
-          console.warn(err);
-          return;
-        }
+      const hasPermissions = await requestAudioPermissions();
+      if (!hasPermissions) {
+        console.log('Permissions not granted');
+        return;
       }
 
       setIsRecording(true);

diff --git a/src/utils/hooks/usePermissions.ts b/src/utils/hooks/usePermissions.ts
@@ -0,0 +1,33 @@
+import { PermissionsAndroid, Platform } from 'react-native';
+
+export const usePermissions = () => {
+  const requestAudioPermissions = async (): Promise<boolean> => {
+    if (Platform.OS === 'android') {
+      try {
+        const grants = await PermissionsAndroid.requestMultiple([
+          PermissionsAndroid.PERMISSIONS.WRITE_EXTERNAL_STORAGE,
+          PermissionsAndroid.PERMISSIONS.READ_EXTERNAL_STORAGE,
+          PermissionsAndroid.PERMISSIONS.RECORD_AUDIO,
+        ]);
+
+        console.log('Permissions status:', grants);
+
+        return (
+          grants['android.permission.WRITE_EXTERNAL_STORAGE'] ===
+            PermissionsAndroid.RESULTS.GRANTED &&
+          grants['android.permission.READ_EXTERNAL_STORAGE'] ===
+            PermissionsAndroid.RESULTS.GRANTED &&
+          grants['android.permission.RECORD_AUDIO'] ===
+            PermissionsAndroid.RESULTS.GRANTED
+        );
+      } catch (err) {
+        console.warn('Permission request failed:', err);
+        return false;
+      }
+    }
+
+    return true;
+  };
+
+  return { requestAudioPermissions };
+};
diff --git a/src/utils/index.ts b/src/utils/index.ts
@@ -1,27 +1 @@
-function formatTimestampToDate(timestamp: number): string {
-  const date = new Date(timestamp);
-  return new Intl.DateTimeFormat('en-US', {
-    month: 'short', // "Jan"
-    day: 'numeric', // "6"
-    year: 'numeric', // "2023"
-  }).format(date);
-}
-
-function formatTimestampToDateTime(timestamp: number): string {
-  const date = new Date(timestamp);
-  const formattedDate = new Intl.DateTimeFormat('en-US', {
-    month: 'short', // "Jan"
-    day: 'numeric', // "6"
-    year: 'numeric', // "2023"
-  }).format(date);
-
-  const formattedTime = new Intl.DateTimeFormat('en-US', {
-    hour: 'numeric', // "6"
-    minute: 'numeric', // "49"
-    hour12: true, // "AM/PM"
-  }).format(date);
-
-  return `${formattedDate} at ${formattedTime}`;
-}
-
-export { formatTimestampToDate, formatTimestampToDateTime };
+export { formatTimestampToDate, formatTimestampToDateTime } from './time';
diff --git a/src/utils/time.ts b/src/utils/time.ts
@@ -0,0 +1,27 @@
+function formatTimestampToDate(timestamp: number): string {
+  const date = new Date(timestamp);
+  return new Intl.DateTimeFormat('en-US', {
+    month: 'short', // "Jan"
+    day: 'numeric', // "6"
+    year: 'numeric', // "2023"
+  }).format(date);
+}
+
+function formatTimestampToDateTime(timestamp: number): string {
+  const date = new Date(timestamp);
+  const formattedDate = new Intl.DateTimeFormat('en-US', {
+    month: 'short', // "Jan"
+    day: 'numeric', // "6"
+    year: 'numeric', // "2023"
+  }).format(date);
+
+  const formattedTime = new Intl.DateTimeFormat('en-US', {
+    hour: 'numeric', // "6"
+    minute: 'numeric', // "49"
+    hour12: true, // "AM/PM"
+  }).format(date);
+
+  return `${formattedDate} at ${formattedTime}`;
+}
+
+export { formatTimestampToDate, formatTimestampToDateTime };