-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jbaker/handle missing flights #145
Conversation
Reviewer's Guide by SourceryThis pull request updates several dependencies, including auro-flightline, auro-library, design-tokens, eslint-config, commitlint, rollup, compression, concurrently, core-js, eslint, eslint-plugin-jsdoc, husky, nodemon, rollup, sass, semantic-release, stylelint, stylelint-config-standard, stylelint-config-standard-scss, stylelint-scss, and typescript. It also modifies the auro-flight-header component to handle cases where there are no flights and updates the documentation to include a default value for the flights property. Sequence diagram showing updated flight type handlingsequenceDiagram
participant C as Client
participant FH as AuroFlightHeader
C->>FH: Get flight type
alt no flights (length = 0)
FH-->>C: return empty string ''
else single flight
FH-->>C: return flight number
else multiple flights
FH-->>C: return default case
end
Class diagram showing changes to AuroFlight and AuroFlightHeader componentsclassDiagram
class AuroFlight {
+Array flights
+constructor()
}
note for AuroFlight "Added default flights=[] in constructor"
class AuroFlightHeader {
+Array flights
+flightType()
}
note for AuroFlightHeader "Modified flightType() to return '' instead of null for empty flights"
AuroFlight <|-- AuroFlightHeader
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jason-capsule42 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
Update
auro-flight
to handle missing flight numbers.Bug Fixes:
Enhancements: