Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(composed screen reader messages): issue #25 - aria-hide element callouts in favor of composed messaging #38

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

shonore-aa
Copy link

@shonore-aa shonore-aa commented Aug 29, 2022

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

The component was updated to be accessibility compliant by allowing screen readers to read the flight duration, flight arrival time, flight departure time, flight arrival station, and flight departure station in a full sentence. Layover, stopover, and nonstop flights are explicitly stated as well. If a flight arrives the next day the screen reader will also indicate this.

Fixes: # 25

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  1. Updated the auro-flight component to take in the stops/layover information
  2. Updated the auro-header to no longer state if a flight is nonstop
  3. Updated the auro-flight-main component to

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2022

CLA assistant check
All committers have signed the CLA.

@aesthetiques aesthetiques force-pushed the shonore/flight-info-accessibility-screen-reader/#25 branch from ab19c4b to 130666c Compare August 29, 2022 18:24
@aesthetiques aesthetiques force-pushed the shonore/flight-info-accessibility-screen-reader/#25 branch from 130666c to 56e7b69 Compare August 29, 2022 18:32
@blackfalcon blackfalcon self-requested a review August 29, 2022 21:48
Copy link
Member

@blackfalcon blackfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge commit 417dd3d regressed a lot of pre 2.0 changes.

This PR cannot be accepted.

@shonore-aa shonore-aa changed the title Shonore/flight info accessibility screen reader/#25 feat(composed screen reader messages): issue #25 - aria-hide element callouts in favor of composed messaging Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants