-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(composed screen reader messages): issue #25 - aria-hide element callouts in favor of composed messaging #38
Draft
shonore-aa
wants to merge
20
commits into
AlaskaAirlines:main
Choose a base branch
from
shonore-aa:shonore/flight-info-accessibility-screen-reader/#25
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d header callouts
…d header callouts
shonore-aa
commented
Aug 29, 2022
aesthetiques
force-pushed
the
shonore/flight-info-accessibility-screen-reader/#25
branch
from
August 29, 2022 18:24
ab19c4b
to
130666c
Compare
aesthetiques
force-pushed
the
shonore/flight-info-accessibility-screen-reader/#25
branch
from
August 29, 2022 18:32
130666c
to
56e7b69
Compare
…irlines#25' of https://github.com/shonore-aa/auro-flight into shonore/flight-info-accessibility-screen-reader/AlaskaAirlines#25
blackfalcon
requested changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The merge commit 417dd3d regressed a lot of pre 2.0 changes.
This PR cannot be accepted.
shonore-aa
changed the title
Shonore/flight info accessibility screen reader/#25
feat(composed screen reader messages): issue #25 - aria-hide element callouts in favor of composed messaging
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
The component was updated to be accessibility compliant by allowing screen readers to read the flight duration, flight arrival time, flight departure time, flight arrival station, and flight departure station in a full sentence. Layover, stopover, and nonstop flights are explicitly stated as well. If a flight arrives the next day the screen reader will also indicate this.
Fixes: # 25
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team