Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container color token name #212

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

jordanjones243
Copy link
Contributor

@jordanjones243 jordanjones243 commented Aug 19, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: # (issue, if applicable)

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Update dependencies
  • Use auro-library build scripts
  • Update color of container token name

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Fix the container color token name in the SCSS file, remove outdated CSS fallback documentation, add a new ESLint configuration file, and clean up obsolete build scripts.

Bug Fixes:

  • Correct the color token name for the container background in the SCSS file to ensure the correct color is applied.

Enhancements:

  • Remove outdated CSS custom property fallback documentation from the README.

Build:

  • Add a new ESLint configuration file to standardize code linting across the project.

Chores:

  • Delete obsolete build scripts related to documentation generation and CSS processing.

@jordanjones243 jordanjones243 self-assigned this Aug 19, 2024
@jordanjones243 jordanjones243 requested a review from a team as a code owner August 19, 2024 21:07
Copy link

sourcery-ai bot commented Aug 19, 2024

Reviewer's Guide by Sourcery

This pull request focuses on updating the color token name for the container in the auro-menuoption component, along with some infrastructure changes. The main changes include updating the background color variable, removing outdated documentation, and updating the build process.

File-Level Changes

Files Changes
src/color-menuoption.scss Updated the background color token name from 'ds-auro-menuoption-background-color' to 'ds-auro-menuoption-container-color'
README.md Removed the section about CSS Custom Property fallbacks from the README
eslint.config.mjs Added a new ESLint configuration file using the new flat config format
scripts/generateDocs.mjs
scripts/postCss.mjs
scripts/prepForBuild.mjs
scripts/staticStyles-template.js
Removed several build and documentation generation scripts

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jordanjones243 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

README.md Show resolved Hide resolved
@jordanjones243 jordanjones243 merged commit 20e9bc5 into beta Aug 19, 2024
4 checks passed
@jordanjones243 jordanjones243 deleted the jjones/fixContainerColor branch August 19, 2024 21:09
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.12.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants