-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MULTI-GITTER PR: migration github-config-and-gitignore-changes #233
MULTI-GITTER PR: migration github-config-and-gitignore-changes #233
Conversation
…thub workflow files
Reviewer's Guide by SourceryThis PR updates various GitHub configuration files and templates to align with current standards and best practices. The changes primarily focus on improving documentation, issue templates, and repository settings. Class diagram for GitHub configuration changesclassDiagram
class GitHubRepository {
+String homepage
+String[] topics
+Boolean has_issues
+Boolean allow_rebase_merge
+Team[] teams
+Branch[] branches
+Label[] labels
}
class Team {
+String name
+String permission
}
class Branch {
+String name
+Protection protection
}
class Protection {
+Boolean required_status_checks
+Boolean enforce_admins
}
class Label {
+String name
+String color
+String description
+String[] aliases
}
GitHubRepository --> Team
GitHubRepository --> Branch
GitHubRepository --> Label
Team --> Permission
Branch --> Protection
Label --> Aliases
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Surge demo deployment failed! 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmenner - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you please explain the rationale for removing the demo files (api.md, api.min.js, index.md, index.min.js)? Are these being moved elsewhere or are they no longer needed?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
🎉 This PR is included in version 4.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary by Sourcery
Update GitHub configuration files to enhance contribution guidelines, streamline issue and pull request processes, and improve CI workflows. Add a new workflow for deploying demo environments and refine existing workflows for better release management.
CI:
Documentation: