Skip to content

Commit

Permalink
fix(log): change task set to task result. (argoproj#12749)
Browse files Browse the repository at this point in the history
Signed-off-by: shuangkun <[email protected]>
  • Loading branch information
shuangkun authored Mar 6, 2024
1 parent e00abd1 commit d805b7f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions workflow/executor/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ func (we *WorkflowExecutor) FinalizeOutput(ctx context.Context) {
common.LabelKeyReportOutputsCompleted: "true",
})
if apierr.IsForbidden(err) {
log.WithError(err).Warn("failed to patch task set, falling back to legacy/insecure pod patch, see https://argo-workflows.readthedocs.io/en/latest/workflow-rbac/")
log.WithError(err).Warn("failed to patch task result, falling back to legacy/insecure pod patch, see https://argo-workflows.readthedocs.io/en/latest/workflow-rbac/")
// Only added as a backup in case LabelKeyReportOutputsCompleted could not be set
err = we.AddAnnotation(ctx, common.AnnotationKeyReportOutputsCompleted, "true")
}
Expand All @@ -820,7 +820,7 @@ func (we *WorkflowExecutor) InitializeOutput(ctx context.Context) {
}, errorsutil.IsTransientErr, func() error {
err := we.upsertTaskResult(ctx, wfv1.NodeResult{})
if apierr.IsForbidden(err) {
log.WithError(err).Warn("failed to patch task set, falling back to legacy/insecure pod patch, see https://argo-workflows.readthedocs.io/en/latest/workflow-rbac/")
log.WithError(err).Warn("failed to patch task result, falling back to legacy/insecure pod patch, see https://argo-workflows.readthedocs.io/en/latest/workflow-rbac/")
// Only added as a backup in case LabelKeyReportOutputsCompleted could not be set
err = we.AddAnnotation(ctx, common.AnnotationKeyReportOutputsCompleted, "false")
}
Expand Down Expand Up @@ -848,7 +848,7 @@ func (we *WorkflowExecutor) reportResult(ctx context.Context, result wfv1.NodeRe
}, errorsutil.IsTransientErr, func() error {
err := we.upsertTaskResult(ctx, result)
if apierr.IsForbidden(err) {
log.WithError(err).Warn("failed to patch task set, falling back to legacy/insecure pod patch, see https://argo-workflows.readthedocs.io/en/latest/workflow-rbac/")
log.WithError(err).Warn("failed to patch task result, falling back to legacy/insecure pod patch, see https://argo-workflows.readthedocs.io/en/latest/workflow-rbac/")
if result.Outputs.HasOutputs() {
value, err := json.Marshal(result.Outputs)
if err != nil {
Expand Down

0 comments on commit d805b7f

Please sign in to comment.