build: upgrade to use nodev20 (argoproj#11410)

Signed-off-by: Rui Chen <[email protected]> Signed-off-by: Alex Collins <[email protected]> Co-authored-by: Yuan Tang <[email protected]> Co-authored-by: Alex Collins <[email protected]>
AlbeeSo · Jul 27, 2023 · d876464 · d876464
1 parent 82876af
commit d876464
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -6,7 +6,7 @@
       "version": "1.20"
     },
     "ghcr.io/devcontainers/features/node:1": {
-      "version": "16"
+      "version": "20"
     },
     "ghcr.io/devcontainers/features/docker-in-docker:2": {},
     "ghcr.io/devcontainers/features/python:1": {}

diff --git a/.github/workflows/ci-build.yaml b/.github/workflows/ci-build.yaml
@@ -250,7 +250,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: "16"
+          node-version: "20"
           cache: yarn
           cache-dependency-path: ui/yarn.lock
       - run: yarn --cwd ui install

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -110,7 +110,7 @@ jobs:
           login-server: quay.io
           username: ${{ secrets.QUAYIO_USERNAME }}
           password: ${{ secrets.QUAYIO_PASSWORD }}
-   
+
       - name: Build & Push Windows Docker Images
         env:
           DOCKERIO_ORG: ${{ secrets.DOCKERIO_ORG }}
@@ -133,7 +133,7 @@ jobs:
               -t $image_name \
               -f Dockerfile.windows \
               .
-          
+
             docker push $image_name
 
             docker tag $image_name quay.io/$image_name
@@ -280,14 +280,14 @@ jobs:
     if: github.repository == 'argoproj/argo-workflows'
     needs: [ push-images, test-images-linux-amd64, test-images-windows ]
     env:
-      NODE_OPTIONS: --max-old-space-size=4096
+      NODE_OPTIONS: --openssl-legacy-provider --max-old-space-size=4096
       COSIGN_PRIVATE_KEY: ${{secrets.COSIGN_PRIVATE_KEY}}
       COSIGN_PASSWORD: ${{secrets.COSIGN_PASSWORD}}
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: "16"
+          node-version: "20"
       - uses: actions/setup-go@v4
         with:
           go-version: "1.20"

diff --git a/Dockerfile b/Dockerfile
@@ -24,7 +24,7 @@ COPY . .
 
 ####################################################################################################
 
-FROM node:16-alpine as argo-ui
+FROM node:20-alpine as argo-ui
 
 RUN apk update && apk add --no-cache git
 
@@ -39,7 +39,7 @@ COPY api api
 
 RUN --mount=type=cache,target=/root/.yarn \
   YARN_CACHE_FOLDER=/root/.yarn JOBS=max \
-  NODE_OPTIONS="--max-old-space-size=2048" JOBS=max yarn --cwd ui build
+  NODE_OPTIONS="--openssl-legacy-provider --max-old-space-size=2048" JOBS=max yarn --cwd ui build
 
 ####################################################################################################
 

diff --git a/ui/package.json b/ui/package.json
@@ -6,13 +6,13 @@
         "src"
     ],
     "scripts": {
-        "build": "rm -Rf dist && NODE_OPTIONS='' NODE_ENV=production webpack --mode production --config ./src/app/webpack.config.js",
-        "start": "NODE_OPTIONS='--no-experimental-fetch' webpack-dev-server --config ./src/app/webpack.config.js",
+        "build": "rm -Rf dist && NODE_OPTIONS='--openssl-legacy-provider' NODE_ENV=production webpack --mode production --config ./src/app/webpack.config.js",
+        "start": "NODE_OPTIONS='--no-experimental-fetch --openssl-legacy-provider' webpack-dev-server --config ./src/app/webpack.config.js",
         "lint": "tslint --fix -p ./src/app",
         "test": "jest"
     },
     "engines": {
-        "node": ">=16"
+        "node": ">=20"
     },
     "dependencies": {
         "argo-ui": "https://github.com/argoproj/argo-ui.git#v2.5.0",