Added GPS directory #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellbertt
reviewed
Oct 9, 2024
GPS/client.py
Outdated
| - terminate - terminates the server and closes connection | ||
|
|
||
|
|
||
| To test the server/client you must run both files in WSL to ensure the use of a |
There was a problem hiding this comment.
You probably don't need to say WSL here, people on linux and mac have a unix environment as well. Maybe just say not windows if you want to specify.
DrakBoul
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Great work Ben and Olivia, this code looks really clean and readable. Before merging, we should address the comment @shellbertt left, as well as adding a README describing what the GPS subsystem should do and how to use your program. I also recommend using markdown instead of a plain text file for the readme, markdown will make it look pretty. To learn how to use markdown you can check out tons of youtube tutorials or you can just check out some other readme files in this repository as a reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.