New version of devise (4.9.3) broke the build #185
Closed
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've tested your project with an updated dependency and the build failed.
This version is either within the version range you specified or you haven't specified a version/range. To be able to test your project with the new version, we've taken the liberty of pinning the version for this branch and pull request.
Unfortunately, we encountered failing tests after pinning. This means that this new version is not compatible with your project and the test failure will potentially also happen on fresh installs.
If you have correctly specified a semantic versioning version range, you should probably also file an issue with the upstream project as they might have released an update that's breaking SemVer rules, which is not cool. (But then again, not all projects explicitly follow SemVer)
We've left the pull request open for you to investigate this issue. Please don't merge it as is, because, again, we've pinned the version of devise for this test run.
What changed?
✳️ devise (>= 4.7.1, < 5 → 4.9.3) · Repo · Changelog
Release Notes
4.9.3 (from changelog)
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 17 commits:
Release v4.9.3
Merge pull request #5640 from nmaggioni/nm_config_template_typo
Better clarify need to override `internal_methods`
Update changelog with Rails 7.1 mention [ci skip]
Fix test warning about deprecated cache format in Rails 7.1
Ensure `_prefixes` is not available as an action method on controllers
Lock ubuntu version to 20.04 to workaround older Ruby build issues
Lock loofah on Rails <= 5.2
Use Bundler 1.x with Ruby <= 2.2
Fix code to support older versions of Ruby
Merge pull request #5628 from soartec-lab/fix/dedicated_active_support_deprecation
Merge pull request #5599 from etiennebarrie/rails-edge-deprecations
Merge pull request #5583 from etiennebarrie/deprecator
Fix mocha warnings with hash vs kwargs
Update mocha to fix issue with Minitest compatibility layer
Use Rails 7.1 on main Gemfile and create a new one for 7.0
Add missing changelog version [ci skip]
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.All Depfu comment commands