Hide element editor errors on save attempt

AlchemyCMS · Jan 24, 2024 · 0123509 · 0123509
1 parent 38f44b9
commit 0123509
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/app/javascript/alchemy_admin/components/element_editor.js b/app/javascript/alchemy_admin/components/element_editor.js
@@ -121,6 +121,7 @@ export class ElementEditor extends HTMLElement {
     this.setClean()
     // Reset errors that might be visible from last save attempt
     this.errorsDisplay.innerHTML = ""
+    this.elementErrors.classList.add("hidden")
     this.body
       .querySelectorAll(".ingredient-editor")
       .forEach((el) => el.classList.remove("validation_failed"))

diff --git a/spec/javascript/alchemy_admin/components/element_editor.spec.js b/spec/javascript/alchemy_admin/components/element_editor.spec.js
@@ -426,6 +426,10 @@ describe("alchemy-element-editor", () => {
         expect(editor.errorsDisplay.innerHTML).toBe("")
       })
 
+      it("hides element errors", () => {
+        expect(editor.elementErrors.classList).toContain("hidden")
+      })
+
       it("removes ingredient invalid state", () => {
         expect(
           editor.querySelector(`[data-ingredient-id="666"]`).classList