Fix web component i18n issues #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Sep 28, 2023
sascha-karnatz
force-pushed
the
web-component-intialization-issues
branch
3 times, most recently
from
959f146 to
fac1888
Compare
tvdeyen
reviewed
Sep 29, 2023
sascha-karnatz
force-pushed
the
web-component-intialization-issues
branch
3 times, most recently
from
3b41303 to
916e50d
Compare
tvdeyen
changed the title
tvdeyen
requested changes
Sep 29, 2023
sascha-karnatz
force-pushed
the
web-component-intialization-issues
branch
3 times, most recently
from
400b24e to
aac6c68
Compare
Add alchemy_i18n gem to test multiple translations in out dummy app.
Export translation and currentLocale function. Move the default translations into locales/en.js and import them directly into the i18n.js to have the translations in place and prevent raise conditions. Remove Alchemy.locale and use the lang attribute of html - element.
remove the Alchemy object from alchemy-tinymce and alchemy-datepicker and use i18n function instead. This reduce the dependencies and prevents raise conditions.
Migrate the character counter component to the default AlchemyHtmlElemenet and rename the max character - attribute. Also removed the Alchemy.t - function and replaced it by the default translate function to prevent raise conditions. Added a spec file to test the component.
Update our styleguide to use our web components for tinymce, character count, and datepicker.
Reload the admin interface completely after a language change to have a proper initialization of locales and the usage of the i18n translate function inside of our web components.
sascha-karnatz
force-pushed
the
web-component-intialization-issues
branch
from
aac6c68 to
b387b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Checklist