Fix language and site creation #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the switch from Turbolinks to Turbo the redirect after submitting the remote form inside the dialog stopped working. The resulting page was rendered inside the dialog instead. Using our own do_redirect_to method that gracefully handles JS remote forms we can fix this.
sascha-karnatz
approved these changes
Oct 6, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
tvdeyen
added a commit
that referenced
this pull request
Oct 6, 2023
[7.0-stable] Merge pull request #2593 from tvdeyen/fix-turbo-redirect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
With the switch from Turbolinks to Turbo the redirect after submitting the remote form inside the dialog stopped working. The resulting page was rendered inside the dialog instead.
Using our own
do_redirect_tomethod that gracefully handles JS remote forms we can fix this.