Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shoelace theme #2597

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Add shoelace theme #2597

merged 1 commit into from
Oct 14, 2023

Conversation

sascha-karnatz
Copy link
Contributor

What is this pull request for?

Add the default Alchemy Shoelace theme. Replaced all color with our colors. Add a custom properties file to store the new variables in it.

Try to remove in the long run the SCSS variables with custom properties. This will allow us to create a dark theme for Alchemy.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the alert style as in 193aee0

app/assets/stylesheets/alchemy/shoelace.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/alchemy/shoelace.scss Outdated Show resolved Hide resolved
@sascha-karnatz sascha-karnatz force-pushed the shoelace-theme branch 2 times, most recently from 46751ca to 8adc1b7 Compare October 13, 2023 12:26
Add the default Alchemy Shoelace theme. Replaced all color with our colors. Add a custom properties file to store the new variables in it.
@tvdeyen tvdeyen merged commit d00cf37 into AlchemyCMS:main Oct 14, 2023
17 checks passed
@tvdeyen tvdeyen added this to the 7.1 milestone Oct 14, 2023
@sascha-karnatz sascha-karnatz deleted the shoelace-theme branch October 16, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants