Prevent publishing of the same page at the same time #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-karnatz
force-pushed
the
harden-page-publisher
branch
2 times, most recently
from
48edabe to
a2a844a
Compare
The idea is to provide a possibility to lock a page inside a transaction to prevent, that two (or more) processes working on the same page. This will be included into the Page::Publisher to prevent, that in parallel running worker are updating the same page and creating duplicate entries. This implementation is heavily inspired by Solidus Spree::OrderMutex.
Prevent publishing the same page at the same time. The PageMutex is locking the page for the time it takes until the page is published. After that the lock is released and it can publish again.
sascha-karnatz
force-pushed
the
harden-page-publisher
branch
2 times, most recently
from
978c193 to
5e0a246
Compare
The CI test pipeline breaks for Rails 7.1. The eager loading results into a Zeitwerk error in the turbo-rails gem. The current solution is to include actioncable if the application is running in a Github Action until this bug is fixed. Ref: hotwired/turbo-rails#512
sascha-karnatz
force-pushed
the
harden-page-publisher
branch
from
5e0a246 to
8fe1bb3
Compare
sascha-karnatz
added
the
backport-to-7.0-stable
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
tvdeyen
added a commit
that referenced
this pull request
Nov 15, 2023
[7.0-stable] Merge pull request #2612 from sascha-karnatz/harden-page-publisher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Introduce the idea of a PageMutex, which is locking the page for the time of an operation and prevent multiple updates at the same time. The PageMutex is now used in the Publisher to prevent multiple updates of the same page.
Checklist