Add a RemoteSelect base component #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
remote-select-component
branch
3 times, most recently
from
2b56122 to
bdf87c9
Compare
Useful for dispatching custom `Alchemy` prefixed events.
tvdeyen
force-pushed
the
remote-select-component
branch
from
bdf87c9 to
5fa2cac
Compare
Extracts whats common on NodeSelect and PageSelect into a RemoteSelect base component
The param used for ransack is filter and not q Also we need to safelist the page association.
Since this has a uniquness validation it is not possible to have more than 3 of it. That makes it hard to test many pages manually.
tvdeyen
force-pushed
the
remote-select-component
branch
from
956edea to
9274425
Compare
sascha-karnatz
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Extracts whats common on NodeSelect and PageSelect into a RemoteSelect base component
Also fixes a filtering bug in the recently added NodeSelect
Checklist