Add nodes to page dialog #2699
Merged
Add nodes to page dialog #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-karnatz
force-pushed
the
node-tab-in-page-configuration
branch
2 times, most recently
from
381a01e to
535ab2d
Compare
sascha-karnatz
force-pushed
the
node-tab-in-page-configuration
branch
8 times, most recently
from
c20465c to
7e4a48e
Compare
sascha-karnatz
changed the title
sascha-karnatz
force-pushed
the
node-tab-in-page-configuration
branch
from
7e4a48e to
8782d70
Compare
sascha-karnatz
added a commit
to sascha-karnatz/alchemy_i18n
that referenced
this pull request
Feb 1, 2024
Add German translations for menu tab in page configuration. Ref: AlchemyCMS/alchemy_cms#2699
sascha-karnatz
added a commit
to sascha-karnatz/alchemy_i18n
that referenced
this pull request
Feb 1, 2024
Add German translations for menu tab in page configuration. Ref: AlchemyCMS/alchemy_cms#2699
sascha-karnatz
force-pushed
the
node-tab-in-page-configuration
branch
from
8782d70 to
a82063b
Compare
tvdeyen
reviewed
Feb 1, 2024
sascha-karnatz
force-pushed
the
node-tab-in-page-configuration
branch
from
a82063b to
378d7e7
Compare
tvdeyen
reviewed
Feb 1, 2024
sascha-karnatz
force-pushed
the
node-tab-in-page-configuration
branch
from
378d7e7 to
f582999
Compare
Add a new menu tab to page configuration dialog. This is a shortcut to create a menu entry for the current page. It is also the first try to provide Turbo Frames inside of Alchemy, which is coming with a few challenges (flash messages, and updated tab headline).
sascha-karnatz
force-pushed
the
node-tab-in-page-configuration
branch
from
f582999 to
061afe6
Compare
tvdeyen
approved these changes
Feb 5, 2024
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| <%= f.hidden_field :page_id, value: @page.id %> | ||
| <%= f.hidden_field :language_id, value: @page.language_id %> | ||
|
|
||
| <%= render Alchemy::Admin::NodeSelect.new(nil, url: alchemy.api_nodes_path(language_id: @page.language_id, include: :ancestors)) do %> |
There was a problem hiding this comment.
Render path contains parameter value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Add a new menu tab to page configuration dialog. This is a shortcut to create a menu entry for the current page. It is also the first try to provide Turbo Frames inside of Alchemy, which is coming with a few challenges (flash messages, and updated tab headline)
Screenshots
Checklist